Use objects to define readable expiration values #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kidonng
commented
Jul 23, 2020
|
It looks good! I think only the docs are missing |
|
@fregante Updated the docs, but I'm not sure if it's done in a proper way |
fregante
reviewed
Jul 26, 2020
Co-authored-by: Fregante <opensource@bfred.it>
fregante
approved these changes
Jul 26, 2020
fregante
changed the title
maxAge
|
Sorry for the delay! I'd like to release this together with another important but breaking change: #7 In the meanwhile, it can be used as the pre-release 4.0.0-0 Thanks for helping! |
|
Never mind! Actually that one is not a breaking change, it still has to support the non-alarm version. I'm publishing v4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #19, using
@sindresorhus/to-millisecondsTests will be updated later